Re: [PATCH] net: smc_close: mark expected switch fall-throughs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>
Date: Thu, 19 Oct 2017 17:02:44 -0500

> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work)
>  	case SMC_PEERCLOSEWAIT1:
>  		if (rxflags->peer_done_writing)
>  			sk->sk_state = SMC_PEERCLOSEWAIT2;
> -		/* fall through to check for closing */
> +		/* to check for closing */
> +		/* fall through */

Gustavo please look at what you are doing to the code.

This was a nice easy to read sentence in the comment, and now
you've chopped it up into two pieces and made it awkward and
more difficult to read.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux