> -----Original Message----- > From: Ursula Braun [mailto:ubraun@xxxxxxxxxxxxxxxxxx] > Sent: Tuesday, October 10, 2017 9:14 AM > To: davem@xxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux- > s390@xxxxxxxxxxxxxxx; jwi@xxxxxxxxxxxxxxxxxx; schwidefsky@xxxxxxxxxx; > heiko.carstens@xxxxxxxxxx; raspl@xxxxxxxxxxxxxxxxxx; > ubraun@xxxxxxxxxxxxxxxxxx; Parav Pandit <parav@xxxxxxxxxxxx> > Subject: [PATCH net 2/2] net/smc: dev_put for netdev after usage of > ib_query_gid() > > For ROCEs ib_query_gid() takes a reference count on the net_device. > This reference count must be decreased by the caller. > > Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> Reported-by: Parav Pandit <parav@xxxxxxxxxxxx> > --- > net/smc/smc_core.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index > 20b66e79c5d6..e93a31ec3cc2 100644 > --- a/net/smc/smc_core.c > +++ b/net/smc/smc_core.c > @@ -380,10 +380,13 @@ static int smc_link_determine_gid(struct > smc_link_group *lgr) > if (ib_query_gid(lnk->smcibdev->ibdev, lnk->ibport, i, &gid, > &gattr)) > continue; > - if (gattr.ndev && > - (vlan_dev_vlan_id(gattr.ndev) == lgr->vlan_id)) { > - lnk->gid = gid; > - return 0; > + if (gattr.ndev) { > + if (vlan_dev_vlan_id(gattr.ndev) == lgr->vlan_id) { This needs to be changed to If (gattr.ndev) { if (is_vlan_dev(gattr.ndev)) && vlan_dev_vlan_id(gattr.ndev) == lgr->vlan_id) { ... } Without this check, on vlan disabled kernel at compile time, kernel will crash on vlan_dev_vlan_id(). Please fix this part, rest code looks fine. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
