On 06/27/2017 02:44 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 27, 2017 at 12:58:29AM +0200, Jiri Olsa escreveu: >> On Thu, Jun 22, 2017 at 09:36:25AM +0200, Thomas Richter wrote: >>> This patch adds platform dependency into the >>> test case 15 (perf_event_attr). It is based on a suggestion from >>> Jiri Olsa. >>> Add a new optional attribute named 'arch' in the [config] section >>> of the test case file. It is a comma separated list of architecture >>> names this test can be executed on. For example: >>> >>> arch = x86_64,alpha,ppc >>> >>> If this attribute is missing the test is executed on any platform. >>> This does not break existing behavior. >>> The values listed for this attribute should be identical to >>> uname -m output. >>> If the list starts with an exclamation mark (!) the comparison is >>> inverted, for example for >>> >>> arch = !s390x,ppc >>> >>> the test is not executed on s390x or ppc platforms. >>> The exclamation mark must be at the beginnning of the list. >>> >>> Here is an example debug output: >>> [root@s35lp76]# fgrep arch tests/attr/test-stat-C2 >>> arch = x86_64,alpha,ppc >>> [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \ >>> -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1 >>> >>> provides the following output: >>> >>> running './tests/attr//test-stat-C1' >>> test limitation 'x86_64,alpha,ppc' <--- new >>> loading expected events >>> Event event:base-stat >>> fd = 1 >>> group_fd = -1 >>> ..... >>> >>> Here is the output when a test is skipped: >>> [root@s35lp76]# fgrep arch tests/attr/test-stat-C1 >>> arch = !s390x >>> [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \ >>> -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1 >>> >>> provides the following output: >>> test limitation '!s390x' <--- new >>> >>> skipped [s390x] './tests/attr//test-stat-C1' <--- new >>> >>> The test is skipped with return code 0. >>> >>> Suggested-by: Jiri Olsa <jolsa@xxxxxxxxxx> >>> Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx> >>> Reviewed-by: Jiri Olsa <jolsa@xxxxxxxxxx> >>> Reviwed-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> >> >> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx> >> >> sorry for delay, I finished my attr tests fixes, you can check >> them in my perf/attr_test_2 branch.. still need to write changelogs ;-) >> >> it passes for me now, however we still might need few fixes >> due to different HW and supported events.. could you please >> test that on your system? >> >> I'll post the changes soon > > Thanks, applied. > > - Arnaldo > Hm, maybe I did something wrong, but I just cloned from url = git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git and when I do a git branch -avv I do not see any perf/attr_test_2 branch. However I see a branch named perf/attr_test. Did I miss something? -- Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294 -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
