From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> Date: Mon, 19 Jun 2017 17:34:25 +0200 > We (as in the s390 guys) tend to add __packed to hardware and hypervisor > structures even if the attribute is not strictly necessary. Most of the > diagnose related structures look that way. Dunno if it is worth to change > them. It causes gcc to generate bad code on certain platforms (yes, probably not yours) and is in general something to avoid. Please do not use __packed unless absolutely necessary. > The diag26c struct needs to be aligned on a doubleword boundary, the > __aligned(8) is necessary. That's fine. > The __packed attribute is again superfluous but follows along the > lines of the other diag structures. Please remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
