Jiri Olsa's
Commit c9666c26ead0 ("perf tests attr: Make compare_data global")
introduced a wrong check on the command's return code exit status test:
- if ret != int(self.ret):
+ if compare_data(str(ret), str(self.ret)):
raise Unsup(self)
This check succeeds when the expected return code matches
the actual return code and raises the Unsup exceptions.
This is not correct.
Revert to the orignal check to raise the exception on
mismatch.
Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx>
---
tools/perf/tests/attr.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/attr.py b/tools/perf/tests/attr.py
index 5787879..d0242d8 100644
--- a/tools/perf/tests/attr.py
+++ b/tools/perf/tests/attr.py
@@ -174,7 +174,7 @@ class Test(object):
log.info(" '%s' ret %d, expected %s" % (cmd, ret, str(self.ret)))
- if compare_data(str(ret), str(self.ret)):
+ if ret != int(self.ret):
raise Unsup(self)
def compare(self, expect, result):
--
2.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
