Hello Sebastian Ott,
The patch c8500e120b81: "s390/cio: use cssid for pgid generation"
from Jun 17, 2016, leads to the following static checker warning:
drivers/s390/cio/css.c:707 css_generate_pgid()
warn: impossible condition '(css->cssid < 0) => (0-255 < 0)'
drivers/s390/cio/css.c
699 static void __init
700 css_generate_pgid(struct channel_subsystem *css, u32 tod_high)
701 {
702 struct cpuid cpu_id;
703
704 if (css_general_characteristics.mcss) {
705 css->global_pgid.pgid_high.ext_cssid.version = 0x80;
706 css->global_pgid.pgid_high.ext_cssid.cssid =
707 (css->cssid < 0) ? 0 : css->cssid;
css->cssid is a u8. I'm not sure what was intended here.
708 } else {
709 css->global_pgid.pgid_high.cpu_addr = stap();
710 }
711 get_cpu_id(&cpu_id);
712 css->global_pgid.cpu_id = cpu_id.ident;
713 css->global_pgid.cpu_model = cpu_id.machine;
714 css->global_pgid.tod_high = tod_high;
715 }
drivers/s390/cio/css.c
725 static ssize_t real_cssid_show(struct device *dev, struct device_attribute *a,
726 char *buf)
727 {
728 struct channel_subsystem *css = to_css(dev);
729
730 if (css->cssid < 0)
^^^^^^^^^^^^^^
Here too.
731 return -EINVAL;
732
733 return sprintf(buf, "%x\n", css->cssid);
734 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
