From: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx>
Date: Thu, 24 Nov 2016 16:06:35 +0100
> +struct smc_clc_msg_hdr { /* header1 of clc messages */
> + u8 eyecatcher[4]; /* eye catcher */
> + u8 type; /* proposal / accept / confirm / decline */
> + __be16 length;
> +#if defined(__BIG_ENDIAN_BITFIELD)
> + u8 version : 4,
> + flag : 1,
> + rsvd : 3;
> +#elif defined(__LITTLE_ENDIAN_BITFIELD)
> + u8 rsvd : 3,
> + flag : 1,
> + version : 4;
> +#endif
> +} __packed;
Please get rid of all of these __packed attributes. They are likely
completely unnecessary and the code generated for this construct on
certain architectures is amazingly inefficient.
Describe the on-wire datastructures properly with fixed sized types
and any padding or overlapping, as needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
