On Sat, 29 Oct 2016 16:38:43 -0400 Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > The Makefile currently controlling compilation of this code is obj-y, > meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular usage, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > Cc: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx> > Cc: linux-s390@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> That idea behind the patch makes sense to me. But the built robot reports a new warning which should be fixed. If that is done: Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html