I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
arch/s390/kernel/idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/idle.c b/arch/s390/kernel/idle.c
index 7a55c29..db60941 100644
--- a/arch/s390/kernel/idle.c
+++ b/arch/s390/kernel/idle.c
@@ -63,7 +63,7 @@ static ssize_t show_idle_count(struct device *dev,
} while (read_seqcount_retry(&idle->seqcount, seq));
return sprintf(buf, "%llu\n", idle_count);
}
-DEVICE_ATTR(idle_count, 0444, show_idle_count, NULL);
+DEVICE_ATTR(idle_count, S_IRUSR | S_IRGRP | S_IROTH, show_idle_count, NULL);
static ssize_t show_idle_time(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -82,7 +82,7 @@ static ssize_t show_idle_time(struct device *dev,
idle_time += idle_enter ? ((idle_exit ? : now) - idle_enter) : 0;
return sprintf(buf, "%llu\n", idle_time >> 12);
}
-DEVICE_ATTR(idle_time_us, 0444, show_idle_time, NULL);
+DEVICE_ATTR(idle_time_us, S_IRUSR | S_IRGRP | S_IROTH, show_idle_time, NULL);
cputime64_t arch_cpu_idle_time(int cpu)
{
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
