I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> --- drivers/s390/crypto/zcrypt_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 5d3d04c..3557e26 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -87,7 +87,7 @@ static ssize_t zcrypt_type_show(struct device *dev, return snprintf(buf, PAGE_SIZE, "%s\n", zdev->type_string); } -static DEVICE_ATTR(type, 0444, zcrypt_type_show, NULL); +static DEVICE_ATTR(type, S_IRUSR | S_IRGRP | S_IROTH, zcrypt_type_show, NULL); static ssize_t zcrypt_online_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -113,7 +113,7 @@ static ssize_t zcrypt_online_store(struct device *dev, return count; } -static DEVICE_ATTR(online, 0644, zcrypt_online_show, zcrypt_online_store); +static DEVICE_ATTR(online, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, zcrypt_online_show, zcrypt_online_store); static struct attribute * zcrypt_device_attrs[] = { &dev_attr_type.attr, -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html