I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>
---
drivers/s390/net/lcs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 251db0a..bac8a04 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -1959,7 +1959,7 @@ lcs_portno_store (struct device *dev, struct device_attribute *attr, const char
}
-static DEVICE_ATTR(portno, 0644, lcs_portno_show, lcs_portno_store);
+static DEVICE_ATTR(portno, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lcs_portno_show, lcs_portno_store);
static const char *lcs_type[] = {
"not a channel",
@@ -1982,7 +1982,7 @@ lcs_type_show(struct device *dev, struct device_attribute *attr, char *buf)
return sprintf(buf, "%s\n", lcs_type[cgdev->cdev[0]->id.driver_info]);
}
-static DEVICE_ATTR(type, 0444, lcs_type_show, NULL);
+static DEVICE_ATTR(type, S_IRUSR | S_IRGRP | S_IROTH, lcs_type_show, NULL);
static ssize_t
lcs_timeout_show(struct device *dev, struct device_attribute *attr, char *buf)
@@ -2016,7 +2016,7 @@ lcs_timeout_store (struct device *dev, struct device_attribute *attr, const char
}
-static DEVICE_ATTR(lancmd_timeout, 0644, lcs_timeout_show, lcs_timeout_store);
+static DEVICE_ATTR(lancmd_timeout, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lcs_timeout_show, lcs_timeout_store);
static ssize_t
lcs_dev_recover_store(struct device *dev, struct device_attribute *attr,
@@ -2036,7 +2036,7 @@ lcs_dev_recover_store(struct device *dev, struct device_attribute *attr,
return count;
}
-static DEVICE_ATTR(recover, 0200, NULL, lcs_dev_recover_store);
+static DEVICE_ATTR(recover, S_IWUSR, NULL, lcs_dev_recover_store);
static struct attribute * lcs_attrs[] = {
&dev_attr_portno.attr,
@@ -2418,7 +2418,7 @@ static ssize_t lcs_driver_group_store(struct device_driver *ddrv,
err = ccwgroup_create_dev(lcs_root_dev, &lcs_group_driver, 2, buf);
return err ? err : count;
}
-static DRIVER_ATTR(group, 0200, NULL, lcs_driver_group_store);
+static DRIVER_ATTR(group, S_IWUSR, NULL, lcs_driver_group_store);
static struct attribute *lcs_drv_attrs[] = {
&driver_attr_group.attr,
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
