On Thu, Aug 20, 2015 at 11:28 PM, David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> > Date: Thu, 20 Aug 2015 15:53:42 +0200 > >> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >> arguments valid for little-endian do not apply to qeth-code. > > You can not throw out generally good tree-wide conventions just because > it happens to work on your platform. > > In fact, I would be really thrilled if some of this code could be compiled > on other platforms via COMPILE_TEST or similar, especially the socket code > and drivers. I have test-compiled this patch on little-endian architecture. I used this script for cross compilation: https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross And it worked fine for me. -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
