On 06/08/2015 19:05, Nicholas Krause wrote:
> This fixes the assumption that kvm_set_irq_routing is always run
> successfully by instead making it equal to the variable r which
> we use for returning in the function kvm_arch_vm_ioctl instead
> of making r equal to zero when calling this particular function
> and incorrectly making the caller of kvm_arch_vm_ioctl think
> the function has run successfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> ---
> arch/s390/kvm/kvm-s390.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index f32f843..660860f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -879,8 +879,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> if (kvm->arch.use_irqchip) {
> /* Set up dummy routing. */
> memset(&routing, 0, sizeof(routing));
> - kvm_set_irq_routing(kvm, &routing, 0, 0);
> - r = 0;
> + r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> }
> break;
> }
>
Seems good.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
