On Thu, 2015-06-11 at 11:59 +0200, Hendrik Brueckner wrote:
> The ENOTSUPP (which actually should be EOPNOTSUPP for user space) does not
> trigger a fallback event selection, for example, by perf record.
> If hardware support for the cycles perf event is available, but the hardware
> does not provide interrupts, returning ENOTSUPP causes perf to end. Returning
> ENOENT causes the perf tool to fallback to a software-based cycle PMU that
> supports interrupts.
>
> The commit 53b25335dd ("perf: Disable sampled events if no PMU interrupt")
> introduced that incompatible change.
That's 3.16
> if (event->pmu->capabilities & PERF_PMU_CAP_NO_INTERRUPT) {
> - err = -ENOTSUPP;
> + err = -ENOENT;
> goto err_alloc;
> }
> }
And now you would be changing an API that's been around for at least 4
releases.
Also, I really think -ENOENT is the wrong return here, you're asking for
things that's not supported, not for something that's not there.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
