On Fri, Feb 07, 2014 at 04:49:18PM +0000, Sudeep Holla wrote:
> From: Sudeep Holla <sudeep.holla@xxxxxxx>
>
> This patch removes the redundant sysfs cacheinfo code by making use of
> the newly introduced generic cacheinfo infrastructure.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
[...]
> -static ssize_t shared_cpu_map_func(struct kobject *kobj, int type, char *buf)
> -{
> - struct cache_index_dir *index;
> - int len;
> + this_leaf->level = level + 1;
> + this_leaf->type = type;
> + this_leaf->coherency_line_size = ecag(EXTRACT_LINE_SIZE, level, ti);
> + this_leaf->ways_of_associativity = ecag(EXTRACT_ASSOCIATIVITY,
> + level, ti);
> + this_leaf->size = ecag(EXTRACT_SIZE, level, ti);
> + if (private)
> + cpumask_set_cpu(cpu, &this_leaf->shared_cpu_map);
> + else /* System wide */
> + cpumask_copy(&this_leaf->shared_cpu_map, cpu_online_mask);
FWIW, this also seems to be wrong: on s390 we only expose cpu private
caches via sysfs. Shared caches are not exposed (and simply saying they are
system wide would be wrong).
Please have a look at these two commits which should describe why things
are as they are on s390:
881730ad365130f64b5c70c40904b04eb3b79de3
"s390/cache: expose cpu cache topology via sysfs"
6668022c7bde3fdc96d3d257294a7216c7a46829
"s390/cache: add cpu cache information to /proc/cpuinfo"
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
