Il 03/07/2013 16:30, Cornelia Huck ha scritto: > + /* > + * Return cookie in gpr 2, but don't overwrite the register if the > + * diagnose will be handled by userspace. > + */ > + if (ret != -EOPNOTSUPP) > + vcpu->run->s.regs.gprs[2] = ret; I think this should now be "if (ret >= 0)". > /* kvm_io_bus_write returns -EOPNOTSUPP if it found no match. */ The comment is now obsolete. > return ret < 0 ? ret : 0; Otherwise looks good, thanks! Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html