Hi Jean, > I think I understand why our s390 (32-bit) kernels do not build. > enable_irq() and free_irq() are defined in arch/s390/pci/pci.c, which is > only built if CONFIG_PCI is set. However PCI depends on 64BIT on S390. > So you should be able to reproduce the failure easily with a 32-bit > allmodconfig build. Ah right... I didn't expect that anybody builds 32 bit kernels anymore (and even dares to use them ;)). BTW, any reason why you don't use 64 bit kernels with compat layer instead? > For our s390x (64-bit) kernels, well it turns out that we have not > selected CONFIG_PCI. I don't know if it was a deliberate choice or an > overlook, I'll ask. But the result is the same, and you should be able > to reproduce the build failure with a 64-bit allmodconfig with > CONFIG_PCI disabled. > > I admit I'm not sure what is the proper way to fix this. Having PCI code > export non-PCI functions seems weird, but unless/until this gets fixed, > the most immediate fix would be: > > From: Jean Delvare <jdelvare@xxxxxxx> > Subject: S390: Fix libphy link failure > > On S390 basic IRQ functions are provided by the PCI subsystem, so > code which calls these cannot be built if PCI support was not > selected. > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > --- > drivers/net/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-3.10-rc0.orig/drivers/net/phy/Kconfig 2013-04-29 02:36:01.000000000 +0200 > +++ linux-3.10-rc0/drivers/net/phy/Kconfig 2013-05-06 10:34:41.141846466 +0200 > @@ -5,6 +5,7 @@ > menuconfig PHYLIB > tristate "PHY Device support and infrastructure" > depends on NETDEVICES > + depends on !S390 || PCI > help > Ethernet controllers are usually attached to PHY > devices. This option provides infrastructure for > > But honestly this isn't very appealing and looks like a step backwards > from what you were trying to achieve in the first place :( Well, I'm fine with your patch. As long as we don't have a nice solution for s390 being the only architecture with !GENERIC_HARDIRQS we will have to live with Kconfig hacks. Unfortunately. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
