On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > > Commit ea81531d ("s390/uaccess: fix page table walk") > > > added this code. It looks like it should have break; > > > for each case. > > no, the fallthrough is on purpose for each case statement. > > Hi again. It might be useful to add /* fallthrough */ > or some other comment showing it's intentional. I might add some comment above the function, since for everybody *knowing* the architecture it's obvious ;) that these must be fallthroughs. How did you stuble across this? -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html