[drivers/tty/serial/8250/8250.c:109:24: fatal error: asm/serial.h: No such file or directory] On 29/03/2013 (Fri 10:53) Fengguang Wu wrote: > > Greetings, > > FYI, kernel build failed on s390 since > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master > head: 9064171268d838b8f283fe111ef086b9479d059a > commit: 9bef3d4197379a995fa80f81950bbbf8d32e9e8b serial: group all the 8250 related code together > date: 1 year, 2 months ago > config: make ARCH=s390 allmodconfig > > All error/warnings: > > drivers/tty/serial/8250/8250.c:58:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function) > >> drivers/tty/serial/8250/8250.c:109:24: fatal error: asm/serial.h: No such file or directory Hi Fengguang, I don't think this is right. It can't be a 14 month old change. The 2nd error itself totally smells like uapi changes. The 1st error makes no sense at all when you look at this: config SERIAL_8250_RUNTIME_UARTS int "Number of 8250/16550 serial ports to register at runtime" depends on SERIAL_8250 How can you build 8250 support and not have a value for the number of runtime UARTs, given the above? I also just checked that mainline v3.9-rc4-158-g9064171 has no problems building drivers/tty/* for s390 while x-compiling in my local test of allmodconfig. Paul. -- > compilation terminated. > > vim +109 drivers/tty/serial/8250/8250.c > > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 52 * Configuration: > 40663cc7 drivers/serial/8250.c Thomas Gleixner 2006-07-01 53 * share_irqs - whether we pass IRQF_SHARED to request_irq(). This option > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 54 * is unsafe when used on edge-triggered interrupts. > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 55 */ > 408b664a drivers/serial/8250.c Adrian Bunk 2005-05-01 56 static unsigned int share_irqs = SERIAL8250_SHARE_IRQS; > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 57 > a61c2d78 drivers/serial/8250.c Dave Jones 2006-01-07 @58 static unsigned int nr_uarts = CONFIG_SERIAL_8250_RUNTIME_UARTS; > a61c2d78 drivers/serial/8250.c Dave Jones 2006-01-07 59 > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 60 static struct uart_driver serial8250_reg; > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 61 > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 62 static int serial_index(struct uart_port *port) > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 63 { > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 64 return (serial8250_reg.minor - 64) + port->line; > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 65 } > 8440838b drivers/serial/8250.c David S. Miller 2008-10-13 66 > d41a4b51 drivers/serial/8250.c Chuck Ebbert 2009-10-01 67 static unsigned int skip_txen_test; /* force skip of txen test at init time */ > d41a4b51 drivers/serial/8250.c Chuck Ebbert 2009-10-01 68 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 69 /* > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 70 * Debugging. > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 71 */ > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 72 #if 0 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 73 #define DEBUG_AUTOCONF(fmt...) printk(fmt) > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 74 #else > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 75 #define DEBUG_AUTOCONF(fmt...) do { } while (0) > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 76 #endif > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 77 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 78 #if 0 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 79 #define DEBUG_INTR(fmt...) printk(fmt) > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 80 #else > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 81 #define DEBUG_INTR(fmt...) do { } while (0) > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 82 #endif > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 83 > e7328ae1 drivers/tty/serial/8250.c Jiri Slaby 2011-06-05 84 #define PASS_LIMIT 512 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 85 > bca47613 drivers/serial/8250.c Dick Hollenbeck 2009-12-09 86 #define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE) > bca47613 drivers/serial/8250.c Dick Hollenbeck 2009-12-09 87 > bca47613 drivers/serial/8250.c Dick Hollenbeck 2009-12-09 88 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 89 /* > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 90 * We default to IRQ0 for the "no irq" hack. Some > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 91 * machine types want others as well - they're free > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 92 * to redefine this in their header file. > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 93 */ > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 94 #define is_real_interrupt(irq) ((irq) != 0) > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 95 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 96 #ifdef CONFIG_SERIAL_8250_DETECT_IRQ > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 97 #define CONFIG_SERIAL_DETECT_IRQ 1 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 98 #endif > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 99 #ifdef CONFIG_SERIAL_8250_MANY_PORTS > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 100 #define CONFIG_SERIAL_MANY_PORTS 1 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 101 #endif > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 102 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 103 /* > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 104 * HUB6 is always on. This will be removed once the header > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 105 * files have been cleaned. > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 106 */ > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 107 #define CONFIG_HUB6 1 > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 108 > a4ed1e41 drivers/serial/8250.c Bryan Wu 2008-05-31 @109 #include <asm/serial.h> > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 110 /* > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 111 * SERIAL_PORT_DFNS tells us about built-in ports that have no > ^1da177e drivers/serial/8250.c Linus Torvalds 2005-04-16 112 * standard enumeration mechanism. Platforms that can find all > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html