On Thu, 6 Sep 2012 09:55:56 +0200
Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> I was checking why this spinlock was never initialized, but it turns
> out it's not used anywhere, so we can drop it.
>
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> I can't even build-test this.
>
> drivers/s390/char/con3270.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-3.6-rc4.orig/drivers/s390/char/con3270.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/s390/char/con3270.c 2012-09-06 09:52:43.801881092 +0200
> @@ -35,7 +35,6 @@ static struct raw3270_fn con3270_fn;
> */
> struct con3270 {
> struct raw3270_view view;
> - spinlock_t lock;
> struct list_head freemem; /* list of free memory for strings. */
>
> /* Output stuff. */
>
>
That is true, the code always uses the view->lock. I'll add this to the queue. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
