On Mon, Jun 11, 2012 at 08:16:02PM -0700, H. Peter Anvin wrote: > On 06/11/2012 08:05 PM, T Makphaibulchoke wrote: > > Cleaning up the file lib/decompress_unxz.c, moving all memory helper functions, > > e.g. memmove, to a new common source file, lib/boot/mem.c. > > > > In additon to including the decompressor, any architecture supporting the XZ > > decompression needs to also include this new source file. > > > > Also moving some other duplicated memory helper functions to this new source > > file from the arm, s390, sh and x86 preboot environments. All 4 architectures > > build without error when using any compression. > > > > Adding a new file lib/boot/mem.c, containing memory helper functions required > > by different compression types. > > > > Adding memcmp declaration workaround and removing the memmove and memcpy > > defines workaround from arch/arm/boot/compressed/decompress.c > > > > Removing the common functions, memmove, memcmp and memset, and adding the new > > source file include to arch/arm/boot/compressed/string.c. > > > > Removing the memcpy and memmove functions and adding the new source file > > include to arch/s390/boot/compressed/misc.c. > > > > Removing the memset function and adding the new source file include to > > arch/sh/boot/compressed/misc.c > > > > Removing the memset function from arch/x86/boot/compressed/misc.c and move > > the memcpy function to the file arch/x86/boot/compressed/string.c > > > > Adding the memcpy function and the new source file include to > > arch/x86/boot/compressed/string.c > > > > I can take this if Russell, Martin or Heiko, and Paul are willing to ack it. Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> Tested-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> (Tested on OMAP4430SDP). -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html