On Tue, Apr 03, 2012 at 09:59:19AM +0200, Jiri Slaby wrote: > On 04/03/2012 07:42 AM, Heiko Carstens wrote: > > On Mon, Apr 02, 2012 at 01:54:09PM +0200, Jiri Slaby wrote: > >> tty_wakeup is safe to be called from all contexts. No need to schedule > >> a tasklet for that. Let us call it directly like in other drivers. > >> > >> And delete the tasklet completely. > > > > Your patch actually reverts Martin's recent commit 656d912537 > > "[S390] 3215 deadlock with tty_wakeup". > > I'm quite sure the reason for the deadlock still exists. > > Unfortunately the commit doesn't contain the call chain that > > led to fix. > > Ok, I would really appreciate the trace. > > If this is really an issue, we should provide a helper in the TTY layer > like tty_schedule_wakeup. Jiri, should I not apply this patch? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
