> From: "David Laight" <David.Laight@xxxxxxxxxx> > To: <frank.blaschka@xxxxxxxxxx>, <davem@xxxxxxxxxxxxx> > Cc: <netdev@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, > <ursula.braun@xxxxxxxxxx> > Date: 07/03/2012 13:20 > Subject: RE: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable > > What is wrong with: > char addr[24]; > snprintf(addr, sizeof addr, "%p", rptr); > > There seemed to be other 'dangerous' unbounded string > operations in that code as well. > > David David, nothing is wrong with your proposal to make use of %p here. Quite the contrary - it improves the ctcmpc-code. I will keep your proposal in my mind for a future follow-on ctcmpc-patch. Thanks! My patch targets compilability of ctcmpc debugging code only. Ursula -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html