On 14/02/12 15:50, David Howells wrote: > Enable the compat keyctl wrapper on s390x so that 32-bit s390 userspace can > call the keyctl() syscall. > > There's an s390x assembly wrapper that truncates all the register values to > 32-bits and this then calls compat_sys_keyctl() - but the latter only exists if > CONFIG_KEYS_COMPAT is enabled, and the s390 Kconfig doesn't enable it. > > Without this patch, 32-bit calls to the keyctl() syscall are given an ENOSYS > error: > > [root@devel4 ~]# keyctl show > Session Keyring > -3: key inaccessible (Function not implemented) > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > Acked-by: dan@xxxxxxxx > cc: Carsten Otte <cotte@xxxxxxxxxx> > cc: Christian Borntraeger <borntraeger@xxxxxxxxxx> > cc: linux-s390@xxxxxxxxxxxxxxx > cc: stable@xxxxxxxxxxxxxxx Patch looks sane. Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> Do you want to push this change via Martins s390 tree or via other trees? > --- > > arch/s390/Kconfig | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index d172758..6d99a5f 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -227,6 +227,9 @@ config COMPAT > config SYSVIPC_COMPAT > def_bool y if COMPAT && SYSVIPC > > +config KEYS_COMPAT > + def_bool y if COMPAT && KEYS > + > config AUDIT_ARCH > def_bool y > > -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
