On Thu, May 12, 2011 at 01:25:51PM +0200, MichaÅ MirosÅaw wrote: > W dniu 12 maja 2011 13:10 uÅytkownik Frank Blaschka > <blaschka@xxxxxxxxxxxxxxxxxx> napisaÅ: > > On Thu, May 12, 2011 at 10:12:51AM +0200, MichaÅ MirosÅaw wrote: > >> W dniu 12 maja 2011 09:21 uÅytkownik Frank Blaschka > >> <blaschka@xxxxxxxxxxxxxxxxxx> napisaÅ: > >> > On Thu, May 12, 2011 at 07:59:45AM +0200, MichaÅ MirosÅaw wrote: > >> >> 2011/5/12 Â<frank.blaschka@xxxxxxxxxx>: > >> >> > Set rx csum default to hw checksumming again. > >> >> > Remove sysfs interface for rx csum (checksumming) and TSO (large_send). > >> >> > With the new hw_features it does not work to keep the old sysfs > >> >> > interface in parallel. Convert options.checksum_type to new hw_features. > >> >> [...] > >> >> > + Â Â Â Â Â Â Â /* hw may have changed during offline or recovery */ > >> >> > + Â Â Â Â Â Â Â if (!qeth_is_supported(card, IPA_INBOUND_CHECKSUM)) { > >> >> [...] > >> >> > >> >> This check should go to ndo_fix_features callback. If it fails then > >> >> just return features &~NETIF_F_RXCSUM from there ... > >> >> > > Ok so all I have to do to complete this is to remove > > Âcard->dev->hw_features &= ~NETIF_F_RXCSUM; > > from here (ndo_fix_feature has already the check)? > > > > Since we might be in recovery it is smarter to keep the support check here so we > > do not have to use try and error approach to see if capabilities have > > changed. Do you aggree? > > The key is that the driver should call netdev_update_features() > whenever some conditions affecting available features might have > changed. If you can keep the checks contained inside ndo_fix_features > callback, you can avoid caring about the offloads in the recovery > process. Ok, we have this now. > > There's also the question what happens when packets are queued while > there's ongoing recovery? Simplest way would be to drop them all until > recovery completes. Since this is RX processing there is nothing queued during recovery. But you are right for tx csum or TSO we have to think about this. For now I would like to complete this patch. > > Best Regards, > MichaÅ MirosÅaw > -- > To unsubscribe from this list: send the line "unsubscribe linux-s390" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html