Bastian, thanks for your feedback. On Sun, Aug 23, 2009 at 10:15:26PM +0200, Bastian Blank wrote: > On Sun, Aug 23, 2009 at 09:37:14PM +0200, Martin Schwidefsky wrote: > > +static void __init set_preferred_console(void) > > +{ > > + if (MACHINE_IS_KVM) { > > + add_preferred_console("hvc", 0, NULL); > > + s390_virtio_console_init(); > > + return; > > + } > > Why this early return instead of else if as all options are mutually > exclusive? Also why do you init the virtio console here instead of an > console_initcall? This is a bug fix to set the respective preferred console device for conmode=3270. To make as few changes as possible for -rc7, the console initialization for kvm has been moved to the new function. You are right that s390_virtio_console_init() should be called from a console_initcall(). I started working on another patch to solve this issue for the next kernel release. Best regards, Hendrik -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html