On Thu 2009-06-04 18:18:52, Martin Schwidefsky wrote: > From: Hans-Joachim Picht <hans@xxxxxxxxxxxxxxxxxx> > > This patch introduces the hibernation backend support to the > s390 architecture. Now it is possible to suspend a mainframe Linux > guest using the following command: > > echo disk > /sys/power/state Should this one be last in series? Otherwise no obvious problems... > Index: linux-2.6/arch/s390/power/swsusp.c > =================================================================== > --- /dev/null > +++ linux-2.6/arch/s390/power/swsusp.c > @@ -0,0 +1,31 @@ > +/* > + * Support for suspend and resume on s390 > + * > + * Copyright IBM Corp. 2009 > + * > + * Author(s): Hans-Joachim Picht <hans@xxxxxxxxxxxxxxxxxx> > + * > + */ > + > +#include <linux/suspend.h> > +#include <linux/gfp.h> > +#include <linux/cpu.h> > +#include <linux/smp.h> > +#include <linux/cpumask.h> > +#include <asm/ipl.h> > +#include <asm/processor.h> Empty functions do not need 1000 includes... > +/* > + * save CPU registers before creating a hibernation image and before > + * restoring the memory state from it > + */ > +void save_processor_state(void) > +{ > +} > + > +/* > + * restore the contents of CPU registers > + */ > +void restore_processor_state(void) > +{ > +} ...and explaining why the functions can be emmpty would be nice. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html