Am Tuesday 10 March 2009 06:10:34 schrieb Stoyan Gaydarov: > +++ b/drivers/s390/char/tape_std.c > @@ -39,8 +39,8 @@ tape_std_assign_timeout(unsigned long data) > int rc; > > request = (struct tape_request *) data; > - if ((device = request->device) == NULL) > - BUG(); > + device = request->device; > + BUG_ON(device == NULL); > > DBF_EVENT(3, "%08x: Assignment timeout. Device busy.\n", > device->cdev_id); Most of the patch look good. Since !pointer seems to be preferred over pointer == NULL, this hunk can be changed to BUG_ON(!device); Christian -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
