Quoting Dan Smith (danms@xxxxxxxxxx): > SH> +static void cr_save_cpu_regs(struct cr_hdr_cpu *hh, struct task_struct *t) > SH> +{ > > <snip> > > SH> + /* per_info */ > SH> + memcpy(&hh->per_control_regs, &thread->per_info.control_regs.words, > SH> + 3 * sizeof(unsigned long)); > SH> + hh->em_instr = 0; > SH> + if (thread->per_info.single_step) > SH> + hh->em_instr |= 1; > SH> + if (thread->per_info.instruction_fetch) > SH> + hh->em_instr |= 2; > > I think that defining these constants (3, 1, and 2) would help me > understand what's being done here. You use them again in > cr_read_cpu(), which also makes it worthwhile I think. Good point, those should be defines. Thanks. -serge -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html