Re: [patch 1/3] af_iucv: add s390dbf debugging support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ursula Braun <ursula.braun@xxxxxxxxxx>
Date: Mon, 01 Dec 2008 10:09:20 +0100

> From: Ursula Braun <ursula.braun@xxxxxxxxxx>
> 
> Add s390dbf entries to facilitate debugging of af_iucv problems.
> 
> Signed-off-by: Ursula Braun <ursula.braun@xxxxxxxxxx>

I have to say this is horrible and something that really doesn't need
to appear under net/

Not only is this an architecture specific debugging hack (instead of
using some well designed generic one), it peppers every core function
with these ugly annotations making the code much harder to read.

Also, you said that these patches are supposed to go into 2.6.28, but
I can't see how that is possible.

Such cleanups and debugging patches like this one are absolutely not
appropriate for -rc phase which we have been in for quite some time.l

So I'm tossing this whole patch set.  If you want to submit just the
specific bug fixes seperately, which would be appropriate for
2.6.28-rc inclusion, please do.  However, I definitely don't want to
see this debug patch again, that's for sure :)
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux