On Tue, Oct 14, 2008 at 08:57:45PM -0400, roel kluin wrote:
> unsigned ops->size cannot be negative
True.
> N.B. It could be possible that a different fix is needed.
Why fix? Does it fix a problem for you?
To me it looks like you removed a pointless check. If this is supposed
to fix any real problem then we need to take closer look.
> diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c
> index a7f8979..a06a47c 100644
> --- a/arch/s390/appldata/appldata_base.c
> +++ b/arch/s390/appldata/appldata_base.c
> @@ -424,7 +424,7 @@ out:
> */
> int appldata_register_ops(struct appldata_ops *ops)
> {
> - if ((ops->size > APPLDATA_MAX_REC_SIZE) || (ops->size < 0))
> + if (ops->size > APPLDATA_MAX_REC_SIZE)
> return -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
