On Tue, 2008-08-26 at 11:38 +1000, Rusty Russell wrote: > On Tuesday 26 August 2008 01:56:30 Martin Schwidefsky wrote: > > On Wed, 2008-08-13 at 14:33 +1000, Rusty Russell wrote: > > > Can you hash the format string to generate the id? 6 hex digits should > > > be enough, and your tool can check for clashes. As it's bad form to have > > > identical strings for different semantics anyway, this seems to make > > > sense. > > > > If we go with hashes there is one more thing: kmsg(0, <string>) > > The variant where we manually assign the message ids knows about the > > "special" id 0. There is no documentation required for id 0 and none is > > wanted. If we replace the manual ids with hashes this will get lost. You > > could argue that a kmsg with id 0 is a normal printk so why not just use > > printk? What is lost is the information that this printk has been found > > to be not important enough to be documented. > > Hmm, #define KERN_IGNORE KERN_DEBUG? Hmm, shouldn't KERN_xxx levels be independent of the special id 0? -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
