On Tue, 2008-08-19 at 08:55 +0300, Artem Bityutskiy wrote: > On Fri, 2008-08-15 at 16:16 +0900, Hirofumi Nakagawa wrote: > > Hi > > Some drivers have duplicated unlikely() macros. > > IS_ERR() already has unlikely() in itself. > > This patch cleans up such pointless codes although there is no real > > effect on the kernel's behaviour. > > > > Thanks, > > Hirofumi Nakagawa > > > > Signed-off-by: Hirofumi Nakagawa <hnakagawa@xxxxxxxxxxxxxxxx> > > --- > > Hmm, after thinking a bit I am not sure this is the right way to go. > Indeed, we try to avoid likly()/unlikely(), unless this is really > hot-path. Some kernel developers even think these hints should never > be used. So I'd say, the right thing would bo to remove unlikely() > from IS_ERR() macro instead. OK, after some googling I tend to thing having unlikely() in IS_ERR() is OK, so I take your patch. Thanks. -- Best regards, Artem Bityutskiy (Битюцкий Артём) -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
