On Thu, 2008-08-07 at 10:31 +0200, Martin Schwidefsky wrote: > On Wed, 2008-08-06 at 13:07 -0700, Greg KH wrote: > > No, I mean use dev_printk() as the base for your logging macro. Add > > your message tag as the first field after the dev_printk() information. > Hmm, you are proposing to introduce a second format for the kmsg > messages to avoid the need for some more printk wrapper macros. To me it > seems that this has two problems: > 1) The message tag is for the user of the system. If it does not have a > fixed position it gets confusing. I think the message tag today is not useful for a user. It seems a barely useful maintainer value. Perhaps the message tag allows for run-time language translation and maybe a bit better selective logging. > 2) The message tag for a driver message usually already includes the > driver name, the dev_printk will print it again. This is ugly and > reduces the quality of the message. Ugly is a beholder problem. Either printk or dev_printk could reorder the output. -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
