On Wed, Jul 30, 2008 at 06:56:57PM +0200, Martin Schwidefsky wrote: > From: Michael Holzheu <holzheu@xxxxxxxxxx> > From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > > Introduce a new family of printk macros which prefixes each kmsg message > with a component name and allows to tag the printk with a message id. > > The kmsg component name is defined per source file with the KMSG_COMPONENT > macro. The first argument of each kmsg printk is the message id. The > message id "0" is special as it will suppress the message id prefix. > > If the message id will be printed to the console / syslog at all depends > on CONFIG_MSG_IDS. If it is "n" then a kmsg_xxx call is just another > printk wrapper. These macros are intended to be used uniformly in the > s390 architecture and the s390 device drivers. > > Signed-off-by: Michael Holzheu <holzheu@xxxxxxxxxx> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > --- > > arch/s390/Kconfig | 9 +++ > include/linux/kmsg.h | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 133 insertions(+) > > Index: linux-2.6/arch/s390/Kconfig > =================================================================== > --- linux-2.6.orig/arch/s390/Kconfig > +++ linux-2.6/arch/s390/Kconfig > @@ -568,6 +568,15 @@ bool "s390 guest support (EXPERIMENTAL)" > select VIRTIO_CONSOLE > help > Select this option if you want to run the kernel under s390 linux > + > +config KMSG_IDS > + bool "Kernel message numbers" > + default y > + help > + Select this option if you want to include a message number to the > + prefix for kernel messages issued by the s390 architecture and > + driver code. See "Documentation/s390/kmsg.txt" for more details. > + > endmenu > > source "net/Kconfig" > Index: linux-2.6/include/linux/kmsg.h > =================================================================== > --- /dev/null > +++ linux-2.6/include/linux/kmsg.h > @@ -0,0 +1,124 @@ > +#ifndef _LINUX_KMSG_H > +#define _LINUX_KMSG_H > + > +#ifndef __KMSG_CHECKER > +#define __KMSG_CHECK(level, id) KERN_##level > +#endif What if __KMSG_CHECKER is enabled? What does __KMSG_CHECK resolve to then? And what sets __KMSG_CHECKER? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
