On Wed, Feb 20, 2008 at 11:09:33AM +0100, Bastian Blank wrote: > On Wed, Feb 20, 2008 at 10:45:52AM +0100, Heiko Carstens wrote: > > - copy_page(lowcore, &S390_lowcore); > > + memcpy(lowcore, &S390_lowcore, 512); > > Okay > > > memset((void *)lowcore + 512, 0, sizeof(*lowcore) - 512); > > Not completely okay. void pointer are not allowed in arithmetic. gcc > handles void * as char * in this case, but I think it should usualy be > avoided. There are many places all over the kernel that assume sizeof(void) == 1. That's yet another gcc extension we use... but I'm going to change that to a char * cast anyway. Thanks for commenting! - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
