On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote: > On Fri, 1 Feb 2008 21:02:08 +0100 > Bastian Blank <bastian@xxxxxxxxxxxx> wrote: > > > Fix ext4 bitops. > > This is incomplete. Please tell us what was "fixed". > > If it was a build error then please quote the compile error output in the > changelog, as well as the usual description of what the problem is, and how > it was fixed. | fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy': | fs/ext4/mballoc.c:954: error: implicit declaration of function 'generic_find_next_le_bit' The s390 specific bitops uses parts of the generic implementation. Include the correct header. > > diff --git a/include/asm-s390/bitops.h b/include/asm-s390/bitops.h > > index dba6fec..47844fc 100644 > > --- a/include/asm-s390/bitops.h > > +++ b/include/asm-s390/bitops.h > > @@ -762,6 +762,8 @@ static inline int sched_find_first_bit(unsigned long *b) > > * 23 22 21 20 19 18 17 16 31 30 29 28 27 26 25 24 > > */ > > > > +#include <asm-generic/bitops/le.h> > > + > > #define ext2_set_bit(nr, addr) \ > > __test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (unsigned long *)addr) > > #define ext2_set_bit_atomic(lock, nr, addr) \ > > > - > To unsubscribe from this list: send the line "unsubscribe linux-s390" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- The idea of male and female are universal constants. -- Kirk, "Metamorphosis", stardate 3219.8 - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
