On Fri, Nov 16, 2007 at 04:09:42PM +0100, Bastian Blank wrote: > On Fri, Nov 16, 2007 at 03:29:45PM +0100, Martin Schwidefsky wrote: > > #else > > static inline void acpi_early_init(void) { } > > #endif > > +#ifdef CONFIG_S390 > > +extern int sclp_init(void); > > +#else > > +static inline int sclp_init(void) {return 0;} > > +#endif > > #ifndef CONFIG_DEBUG_RODATA > > static inline void mark_rodata_ro(void) { } > > #endif > > @@ -643,6 +648,7 @@ asmlinkage void __init start_kernel(void > > check_bugs(); > > > > acpi_early_init(); /* before LAPIC and SMP init */ > > + sclp_init(); > > What happens if sclp_init fails? The other early init calls explicitely > returns void and handels the error internal. Nothing. I used to have an sclp call within __cpu_up() but that is gone since I rewrote the patch that follows this one. So this patch is just a leftover and I forgot that it isn't needed anymore. Will be dropped. Thanks for the hint! - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html