Hi Andrew, The kernel build fails on S390, with error CC [M] fs/freevxfs/vxfs_inode.o fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget' fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget' fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here make[2]: *** [fs/freevxfs/vxfs_inode.o] Error 1 make[1]: *** [fs/freevxfs] Error 2 make: *** [fs] Error 2 This error is caused by iget-stop-freevxfs-from-using-iget-and-read_inode.patch, where the function proto type is declared as vxfs_iget(struct super_block *, unsigned long) and defined as vxfs_iget(struct super_block *sbp, ino_t ino) This patch has been tested for the buid failure. Signed-off-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> -- --- linux-2.6.24-rc1/fs/freevxfs/vxfs_extern.h 2007-11-06 17:04:04.000000000 +0530 +++ linux-2.6.24-rc1/fs/freevxfs/~vxfs_extern.h 2007-11-07 00:45:09.000000000 +0530 @@ -58,7 +58,7 @@ extern struct inode * vxfs_get_fake_ino extern void vxfs_put_fake_inode(struct inode *); extern struct vxfs_inode_info * vxfs_blkiget(struct super_block *, u_long, ino_t); extern struct vxfs_inode_info * vxfs_stiget(struct super_block *, ino_t); -extern struct inode * vxfs_iget(struct super_block *, unsigned long); +extern struct inode * vxfs_iget(struct super_block *sbp, ino_t ino); extern void vxfs_clear_inode(struct inode *); /* vxfs_lookup.c */ -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html