Re: [PATCH] Fix priority mistakes in drivers/s390/cio/cmf.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 26, 2007 at 11:47:54PM +0200, Roel Kluin wrote:
> Fixes priority mistakes similar to '!x & y'
>     
> Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
> ---
> diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c
> index b960f66..6de9d7e 100644
> --- a/drivers/s390/cio/cmf.c
> +++ b/drivers/s390/cio/cmf.c
> @@ -343,10 +343,10 @@ static int cmf_copy_block(struct ccw_device *cdev)
> 
>  	if (sch->schib.scsw.fctl & SCSW_FCTL_START_FUNC) {
>  		/* Don't copy if a start function is in progress. */
> -		if ((!sch->schib.scsw.actl & SCSW_ACTL_SUSPENDED) &&
> +		if ((!(sch->schib.scsw.actl & SCSW_ACTL_SUSPENDED)) &&
>  		    (sch->schib.scsw.actl &
>  		     (SCSW_ACTL_DEVACT | SCSW_ACTL_SCHACT)) &&
> -		    (!sch->schib.scsw.stctl & SCSW_STCTL_SEC_STATUS))
> +		    (!(sch->schib.scsw.stctl & SCSW_STCTL_SEC_STATUS)))
>  			return -EBUSY;
>  	}
>  	cmb_data = cdev->private->cmb;

Applied to our tree. Thanks! How did you find that one?
-
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux