On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: > On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > headers can be used with gcc's -std=c99. > > We should not allow inline assemly in the exported part of userspace headers > at all. These headers must only include defintions for the kernel <-> user > ABI, and should not include code at all. Do you imply that if we see asm or __asm__ in user space headers we ougth to warn about it? Seems at least sensible to me but if we introduce such a check we should kill all offenders first - which Mike's patches seems to trigger for some part. Sam - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html