On Thu, Apr 26, 2007 at 02:32:06AM +0200, Arnd Bergmann wrote: > On Thursday 26 April 2007, Andrew Morton wrote: > > It would be neat if someone could create and maintain a new > > scripts/spot-common-mistakes. Feed it a unified diff and it would complain > > about newly-added code (and only newly-added code) which has busted > > whitespace, adds new semaphores, adds new kernel_thread calls, etc, etc. > > http://patchstylecheck.googlecode.com/svn/trunk/patchstylecheckemail.pl > Might serve as a starting point for this. It doesn't have any semantic > checks right now, but I guess they can be added. Had run this utility against my battery patches, and caught bunch of false positives (I believe). +#define BATTERY_PROP(bat, prop) ({ \ + void *value = bat->get_property(bat, BATTERY_PROP_##prop); \ + value ? *(int*)value : 0; \ +}) Got: "Macros with multiple statements should be enclosed in a do - while loop" I believed ({}) is equivalent for "do - while", it's widely used in kernel. + switch (bp) { + default: break; + }; Got "Gotos should not be indented", at "default: break;" +static int bind_pst_to_psy(struct power_supplicant *pst, + struct power_supply *psy) +{ Got "use tabs not spaces". Here spaces intentionally used for formatting purpose, not for the indenting. - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
