On Sat, Feb 10, 2007 at 05:14:13PM -0500, Tejun Heo wrote: > Heiko Carstens wrote: > >On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: > \>> Heiko, how about this? Does it fix s390? > > > >Unfortunately not. Now I get > > > > CC lib/iomap.o > >lib/iomap.c: In function 'devm_ioport_map_release': > >lib/iomap.c:270: warning: implicit declaration of function 'ioport_unmap' > >lib/iomap.c: In function 'devm_ioport_map': > >lib/iomap.c:297: warning: implicit declaration of function 'ioport_map' > >lib/iomap.c:297: warning: assignment makes pointer from integer without a > >cast > > I think an arch needs to support ioport_map/unmap and noncoherent dma > (just alias to coherent interface on x86/amd64) interface whether PCI is > implemented or not. No? Another source of breakage: you get devm_request_irq() only if you have GENERIC_HARDIRQS. Otherwise kernel/irq/ is simply not built. Again, you are mixing default implementation of primitives with the implementation-agnostic stuff around those primitives. I'd split kernel/irq/manage.c in two files and have the places providing alternative implementations (e.g. arch/sparc/kernel) refer to new file in their makefiles... I'm mostly done with that stuff, modulo noncoherent_dma breakage. Will send patch once the irq crap is dealt with... - To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
