The trace call invokes rtc_tm_to_time64 on a
potentially uninitialized alarm->time. Move the
trace call to the path where we do successfully
initialize and read that struct.
This fixes a KMSAN warning.
Fixes: 29a1f599c0cc ("rtc: Add tracepoints for RTC system")
Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@xxxxxxxxx>
---
drivers/rtc/interface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
index aaf76406cd7d..82ba33bf478b 100644
--- a/drivers/rtc/interface.c
+++ b/drivers/rtc/interface.c
@@ -201,11 +201,12 @@ static int rtc_read_alarm_internal(struct rtc_device *rtc,
alarm->time.tm_yday = -1;
alarm->time.tm_isdst = -1;
err = rtc->ops->read_alarm(rtc->dev.parent, alarm);
+ if (!err)
+ trace_rtc_read_alarm(rtc_tm_to_time64(&alarm->time), err);
}
mutex_unlock(&rtc->ops_lock);
- trace_rtc_read_alarm(rtc_tm_to_time64(&alarm->time), err);
return err;
}
--
2.48.1
