Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/02/2025 18:16, Alexandre Belloni wrote:
> On 25/02/2025 18:12:10+0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 17:34, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>>
>>> Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
>>> CONFIG_ACPI is disabled:
>>>
>>> drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> I already sent a fix for this few days ago:
>>
>> https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@xxxxxxxxxx/
>>
> 
> But wouldn't Arnd's one be better?

ACPI table can be here entirely dropped and driver will match via
PRP0001, so I think ACPI_PTR makes sense.

But if you have arguments for keeping both, sure... There was no
response to my trivial patch and multiple people will be wasting same
time on the same issue. So just apply whichever of these, before third
person wastes more time on that warning.

Best regards,
Krzysztof




[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux