Re: [PATCH v1 1/7] dt-bindings: rtc: add new type for epson,rx8901

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 10, 2025 at 07:13:55AM +0100, Markus Burri wrote:
> Add new compatibility string for the epson rx8901 chip.
> The chip has input pins for tamper detection.
> This patch add a new compatibility string for this type. This is

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> needed to enable the functionality for this type of chip.
> 
> The compatibility string is defined in the driver but not documented
> in dt-bindings.
> 
> The patch also add compatibility string for epson,rx8803.
> The type is supported by the driver but not documented.

All four sentences keep repeating the same, so just:

"Document compatibles for RX8901 and RX8803, which are already used by
the driver."

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof





[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux