On 27/12/2024 at 18:57, Ming Yu wrote: > This driver supports Socket CANfd functionality for NCT6694 MFD > device based on USB interface. > > Signed-off-by: Ming Yu <a0282524688@xxxxxxxxx> > --- (...) > +config CAN_NCT6694 > + tristate "Nuvoton NCT6694 Socket CANfd support" > + depends on MFD_NCT6694 I think it would be better to do a select MFD_NCT6694 here. Then, make MFD_NCT6694 an hidden configuration in a similar fashion as MFD_CORE. Alone, CONFIG_MFD_NCT6694 does nothing, so better to hide it from the end user. The comment also applies to the other patches. > + help > + If you say yes to this option, support will be included for Nuvoton > + NCT6694, a USB device to socket CANfd controller. > + > + This driver can also be built as a module. If so, the module will > + be called nct6694_canfd. > + (...) Yours sincerely, Vincent Mailhol
