From: Peng Fan <peng.fan@xxxxxxx> Without remove hook to clear wake irq, there will be kernel dump when doing module test. "bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized" Add remove hook to clear wake irq and set wakeup to false. Fixes: eb7b85853c38 ("rtc: bbnsm: Add the bbnsm rtc support") Signed-off-by: Peng Fan <peng.fan@xxxxxxx> --- drivers/rtc/rtc-nxp-bbnsm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index acbfbeb8b070..fa88fd8ffadf 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -206,6 +206,12 @@ static int bbnsm_rtc_probe(struct platform_device *pdev) return devm_rtc_register_device(bbnsm->rtc); } +static void bbnsm_rtc_remove(struct platform_device *pdev) +{ + dev_pm_clear_wake_irq(&pdev->dev); + device_init_wakeup(&pdev->dev, false); +} + static const struct of_device_id bbnsm_dt_ids[] = { { .compatible = "nxp,imx93-bbnsm-rtc" }, { /* sentinel */ }, @@ -218,6 +224,7 @@ static struct platform_driver bbnsm_rtc_driver = { .of_match_table = bbnsm_dt_ids, }, .probe = bbnsm_rtc_probe, + .remove_new = bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver); -- 2.37.1