This looks good, can you send v7 adressint Conor's comment, don't forget to collect his tag. On 29/08/2024 13:31:43+0200, Tóth János via B4 Relay wrote: > This patch series adds a driver and the documentation for the SD2405AL I2C RTC. > > To: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > To: Rob Herring <robh@xxxxxxxxxx> > To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> > To: Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-rtc@xxxxxxxxxxxxxxx > Cc: csokas.bence@xxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Tóth János <gomba007@xxxxxxxxx> > > Changes in v6: > - Add missing To-s and Cc-s. > - Rebased onto v6.11-rc5 > - Link to v5: https://lore.kernel.org/r/20240828-rtc-sd2405al-v5-0-9e3f8fa5ea6b@xxxxxxxxx > > Changes in v5: > - Rework based on Alexandre Belloni's suggestions. > - Drop explicit initialization of struct i2c_device_id::driver_data. > - Add documentation. > - Link to v4: https://lore.kernel.org/r/20240624-rtc-sd2405al-v4-1-2b2bc759f98f@xxxxxxxxx > > Changes in v4: > - Implement more comprehensive data validation. > - Inline some temporary variables. > - Link to v3: https://lore.kernel.org/r/20240620-rtc-sd2405al-v3-1-65d5bb01af50@xxxxxxxxx > > Changes in v3: > - #define-s of registers are reworked. > - Minor revisions based on the reviewer's suggestions. > - Link to v2: https://lore.kernel.org/r/20240619-rtc-sd2405al-v2-1-39bea29bd2a5@xxxxxxxxx > > Changes in v2: > - Refactored based on reviewer's suggestions. > - I couldn't get the I2C IRQ to work on Raspberry Pi 4, so alarm is > skipped. > - Link to v1: https://lore.kernel.org/r/20240607-rtc-sd2405al-v1-1-535971e7a866@xxxxxxxxx > > --- > Tóth János (2): > drivers: rtc: Add driver for SD2405AL. > dt-bindings: rtc: Add support for SD2405AL. > > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > MAINTAINERS | 6 + > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-sd2405al.c | 227 +++++++++++++++++++++ > 6 files changed, 248 insertions(+) > --- > base-commit: 5be63fc19fcaa4c236b307420483578a56986a37 > change-id: 20240607-rtc-sd2405al-a0947377c73d > > Best regards, > -- > Tóth János <gomba007@xxxxxxxxx> > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
