On 23/08/2024 17:35, Karthikeyan Krishnasamy wrote: > Add i2s0 node and possible pinctrl for Rockchip RV1126 > > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@xxxxxxxxxxx> > --- > .../arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 102 ++++++++++++++++++ > arch/arm/boot/dts/rockchip/rv1126.dtsi | 26 +++++ > 2 files changed, 128 insertions(+) ... > + i2s0m1_sdo1_sdi3: i2s0m1-sdo1_sdi3 { > + rockchip,pins = > + /* i2s0_sdo1_sdi3_m1 */ > + <3 RK_PB3 3 &pcfg_pull_none>; > + }; > + i2s0m1_sdo2_sdi2: i2s0m1-sdo2_sdi2 { > + rockchip,pins = > + /* i2s0_sdo2_sdi2_m1 */ > + <3 RK_PB4 3 &pcfg_pull_none>; Weird alignment... > + }; > + i2s0m1_sdo3_sdi1: i2s0m1-sdo3_sdi1 { No underscores in node names, > + rockchip,pins = > + /* i2s0_sdo3_sdi1_m1 */ > + <3 RK_PB5 3 &pcfg_pull_none>; > + }; > + }; Best regards, Krzysztof